[SPARK-9955][SQL] correct error message for aggregate#8203
[SPARK-9955][SQL] correct error message for aggregate#8203cloud-fan wants to merge 2 commits intoapache:masterfrom
Conversation
|
Test build #40880 has finished for PR 8203 at commit
|
There was a problem hiding this comment.
Can you please move this to AnalysisErrorSuite?
There was a problem hiding this comment.
The UnresolvedAlias is only introduced when parsing SQL or DataFrame, so if we move this test into AnalysisErrorSuite, we need to add the UnresolvedAliases manually, is that OK?
There was a problem hiding this comment.
Or construct the plan by hand? Or we could maybe start a dataframe error
suite.
On Aug 14, 2015 8:26 PM, "Wenchen Fan" notifications@github.com wrote:
In sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
#8203 (comment):
- sqlContext.dropTempTable("1one")
- test("SPARK-9955: correct error message for aggregate") {
- val e = intercept[AnalysisException] {
sql("select key, max(value) from testData where bad_column > 1 group by key")The UnresolvedAlias is only introduced when parsing SQL or DataFrame, so
if we move this test into AnalysisErrorSuite, we need to add the
UnresolvedAliases manually, is that OK?—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/8203/files#r37132757.
|
Test build #40951 has finished for PR 8203 at commit
|
|
Thanks! Merging to master and branch-1.5 |
We should skip unresolved `LogicalPlan`s for `PullOutNondeterministic`, as calling `output` on unresolved `LogicalPlan` will produce confusing error message. Author: Wenchen Fan <cloud0fan@outlook.com> Closes #8203 from cloud-fan/error-msg and squashes the following commits: 1c67ca7 [Wenchen Fan] move test 7593080 [Wenchen Fan] correct error message for aggregate (cherry picked from commit 5705672) Signed-off-by: Michael Armbrust <michael@databricks.com>
We should skip unresolved `LogicalPlan`s for `PullOutNondeterministic`, as calling `output` on unresolved `LogicalPlan` will produce confusing error message. Author: Wenchen Fan <cloud0fan@outlook.com> Closes apache#8203 from cloud-fan/error-msg and squashes the following commits: 1c67ca7 [Wenchen Fan] move test 7593080 [Wenchen Fan] correct error message for aggregate
3 participants
We should skip unresolved
LogicalPlans forPullOutNondeterministic, as callingoutputon unresolvedLogicalPlanwill produce confusing error message.